fix: put a timeout to callers of methods that use singleflight#3048
Draft
miparnisari wants to merge 1 commit intomainfrom
Draft
fix: put a timeout to callers of methods that use singleflight#3048miparnisari wants to merge 1 commit intomainfrom
miparnisari wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3048 +/- ##
==========================================
+ Coverage 75.51% 75.57% +0.06%
==========================================
Files 502 502
Lines 61769 61805 +36
==========================================
+ Hits 46638 46702 +64
+ Misses 11716 11699 -17
+ Partials 3415 3404 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
deadlock-singleflight
branch
2 times, most recently
from
38517ea to
866fb65
Compare
miparnisari
force-pushed
the
deadlock-singleflight
branch
2 times, most recently
from
45d61a2 to
d6f53ed
Compare
github-actions
Bot
added
area/cli
miparnisari
changed the title
miparnisari
commented
May 7, 2026
Comment on lines
-546
to
-548
| features, _, err := cds.featuresGroup.Do(ctx, "", func(ictx context.Context) (*datastore.Features, error) { | ||
| return cds.features(ictx) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
FYI this is a refactor - i dislike having singleflight uses scattered in many places.
miparnisari
force-pushed
the
deadlock-singleflight
branch
3 times, most recently
from
1c6f606 to
efb210f
Compare
miparnisari
force-pushed
the
deadlock-singleflight
branch
from
efb210f to
a0c6c4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Potential fix for #2788
TO DO: discuss with @josephschorr. I want to overhaul the singleflight code (specifically
singleflight.go,optimized.go, andcontext.go).optimized.gointosingleflight.gomove CRDB'sfeatureGroupintosingleflight.goTesting
reproduce_deadlock.sh
docker-compose.deadlock.yaml
References